Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so old maps on modern servers will have a min y = 0, meaning you can't build under y=0, so it behaves as they used to.
To make this happen a bunch of horrible hacks were employed:
This would've been alot easier of paper supported modifying the dimensionType as part of world creator, and supported dimension type as a modifiable registry.
It can still be cleaned up now that i got it to a stage that works, but i don't think there's a work-around for the use of unsafe to access unmodifiable fields.
Ontop of this all, it seems that if the world is created with a different dimensions some world conversion doesn't run, leaving fences or glass panes unconnected. Opened PaperMC/DataConverter#22 to see if we can get any help for this, in the form of a fix, or a workaround of some sortsBy registering our own data fix that modifies the dimension we've been able to workaround this one